X-Git-Url: http://git.refcnt.org/?a=blobdiff_plain;f=test.pl;h=40c3cb52187b272f90183c8e96e6a5bf5bfc47d1;hb=bf223df46d9b78354c2045170e93385efe73a7f4;hp=056f818d7b4d6d27c6649e9572fb1eb025baa4e1;hpb=bc00d671241fb5509b81a13efdf50cae616610d0;p=colorize.git

diff --git a/test.pl b/test.pl
index 056f818..40c3cb5 100755
--- a/test.pl
+++ b/test.pl
@@ -2,19 +2,24 @@
 
 use strict;
 use warnings;
-use constant true => 1;
+use constant true  => 1;
+use constant false => 0;
 
-use File::Temp qw(tempfile tmpnam);
+use File::Temp qw(tempfile tempdir tmpnam);
+use IPC::Open3 qw(open3);
+use Symbol qw(gensym);
+use Test::Harness qw(runtests);
 use Test::More;
 
-my $tests = 22;
+my $tests = 25;
 
 my %BUF_SIZE = (
    normal => 1024,
    short  => 10,
 );
 my $source = 'colorize.c';
-my $warning_flags = '-Wall -Wextra -Wformat -Wswitch-default -Wuninitialized -Wunused -Wno-unused-function -Wno-unused-parameter';
+my $compiler = 'gcc';
+my $compiler_flags = '-ansi -pedantic -Wall -Wextra -Wformat -Wswitch-default -Wuninitialized -Wunused -Wno-unused-function -Wno-unused-parameter';
 
 my $write_to_tmpfile = sub
 {
@@ -27,18 +32,74 @@ my $write_to_tmpfile = sub
     return $tmpfile;
 };
 
+{
+    my @test_files = glob('t/*.t');
+    eval { runtests(@test_files) } or warn $@;
+}
+
 plan tests => $tests;
 
 SKIP: {
     skip "$source does not exist", $tests unless -e $source;
 
+    my $binary = tmpnam();
+    skip 'compiling failed', $tests unless system("$compiler $compiler_flags -o $binary $source") == 0;
+    unlink $binary;
+
     my $program = tmpnam();
-    skip 'compiling failed (normal)', $tests unless system("gcc -DTEST -DBUF_SIZE=$BUF_SIZE{normal} $warning_flags -o $program $source") == 0;
+    skip 'compiling failed (normal)', $tests unless system("$compiler -DTEST -DBUF_SIZE=$BUF_SIZE{normal} -o $program $source") == 0;
+
+    is(system("$program --help >/dev/null 2>&1"),    0, 'exit value for help screen');
+    is(system("$program --version >/dev/null 2>&1"), 0, 'exit value for version data');
+
+    my $run_program_fail = sub
+    {
+        my ($program, $args, $message) = @_;
 
-    is(system("$program --help >/dev/null 2>&1"), 0, 'exit value for help screen');
+        my @args = split /\s+/, $args;
 
-    is(qx(echo    "hello world" | $program none/none), "hello world\n", 'line read from stdin with newline');
-    is(qx(echo -n "hello world" | $program none/none), "hello world",   'line read from stdin without newline');
+        my $err = gensym;
+
+        my $pid = open3(gensym, gensym, $err, $program, @args);
+        waitpid($pid, 0);
+
+        my $output = do { local $/; <$err> };
+
+        return ($? >> 8 == 1 && $output =~ /$message/) ? true : false;
+    };
+
+    {
+        my $ok = true;
+
+        my $file = $write_to_tmpfile->('abc');
+        my $dir  = tempdir(CLEANUP => true);
+
+        $ok &= $run_program_fail->($program, '--exclude-random=random', 'must be provided a plain color');
+        $ok &= $run_program_fail->($program, '--clean --clean-all',     'mutually exclusive');
+        $ok &= $run_program_fail->($program, '--clean file1 file2',     'more than one file');
+        $ok &= $run_program_fail->($program, '--clean-all file1 file2', 'more than one file');
+        $ok &= $run_program_fail->($program, '- file',                  'hyphen cannot be used as color string');
+        $ok &= $run_program_fail->($program, '-',                       'hyphen must be preceeded by color string');
+        $ok &= $run_program_fail->($program, "$file file",              'cannot be used as color string');
+        $ok &= $run_program_fail->($program, "$file",                   'must be preceeded by color string');
+        $ok &= $run_program_fail->($program, "$dir",                    'is not a valid file type');
+        $ok &= $run_program_fail->($program, '/black',                  'foreground color missing');
+        $ok &= $run_program_fail->($program, 'white/',                  'background color missing');
+        $ok &= $run_program_fail->($program, 'white/black/yellow',      'one color pair allowed only');
+        $ok &= $run_program_fail->($program, 'y3llow',                  'cannot be made of non-alphabetic characters');
+        $ok &= $run_program_fail->($program, 'yEllow',                  'cannot be in mixed lower/upper case');
+        $ok &= $run_program_fail->($program, 'None',                    'cannot be bold');
+        $ok &= $run_program_fail->($program, 'white/Black',             'cannot be bold');
+
+        foreach my $color_pair (qw(random/none random/default none/random default/random)) {
+            $ok &= $run_program_fail->($program, $color_pair, 'cannot be combined with');
+        }
+
+        ok($ok, 'exit messages/values for failures');
+    }
+
+    is(qx(printf '%s\n' "hello world" | $program none/none), "hello world\n", 'line read from stdin with newline');
+    is(qx(printf  %s    "hello world" | $program none/none), "hello world",   'line read from stdin without newline');
 
     my $text = do { local $/; <DATA> };
 
@@ -57,7 +118,7 @@ SKIP: {
 
         my $ok = true;
         foreach my $value (@values) {
-            $ok &= qx(echo -n "\e[${value}m" | $program --clean) eq '';
+            $ok &= qx(printf %s "\e[${value}m" | $program --clean) eq '';
         }
         ok($ok, 'clean color sequences');
     }
@@ -68,16 +129,16 @@ SKIP: {
 
         my $switch = "--$type";
 
-        is(qx(echo -n "\e[35mhello\e[0m \e[36mworld\e[0m" | $program $switch),       'hello world', "$type colored words");
-        is(qx(echo -n "hello world" | $program Magenta | $program $switch),          'hello world', "$type colored line");
+        is(qx(printf %s "\e[35mhello\e[0m \e[36mworld\e[0m" | $program $switch),     'hello world', "$type colored words");
+        is(qx(printf %s "hello world" | $program Magenta | $program $switch),        'hello world', "$type colored line");
         is_deeply([split /\n/, qx($program cyan $infile1 | $program $switch)], [split /\n/, $text], "$type colored text");
 
-        ok(qx(echo -n "\e[\e[33m" | $program $switch) eq "\e[", "$type with invalid sequence");
+        ok(qx(printf %s "\e[\e[33m" | $program $switch) eq "\e[", "$type with invalid sequence");
     };
 
     $check_clean->($_) foreach qw(clean clean-all);
 
-    is(qx(echo -n "\e[4munderline\e[24m" | $program --clean-all), 'underline', 'clean-all color sequences');
+    is(qx(printf %s "\e[4munderline\e[24m" | $program --clean-all), 'underline', 'clean-all color sequences');
 
     my $check_clean_buf = sub
     {
@@ -85,14 +146,14 @@ SKIP: {
 
         my $switch = "--$type";
 
-        # Check that line chunks are merged when cleaning text
+        # Check that line chunks are printed when cleaning text without sequences
         my $short_text = 'Linux dev 2.6.32-5-openvz-686 #1 SMP Sun Sep 23 11:40:07 UTC 2012 i686 GNU/Linux';
-        is(qx(echo -n "$short_text" | $program_buf $switch), $short_text, "merge ${\length $short_text} bytes (BUF_SIZE=$BUF_SIZE{short}, $type)");
+        is(qx(printf %s "$short_text" | $program_buf $switch), $short_text, "print ${\length $short_text} bytes (BUF_SIZE=$BUF_SIZE{short}, $type)");
     };
 
     SKIP: {
         my $program_buf = tmpnam();
-        skip 'compiling failed (short buffer)', 2 unless system("gcc -DTEST -DBUF_SIZE=$BUF_SIZE{short} $warning_flags -o $program_buf $source") == 0;
+        skip 'compiling failed (short buffer)', 2 unless system("$compiler -DTEST -DBUF_SIZE=$BUF_SIZE{short} -o $program_buf $source") == 0;
         $check_clean_buf->($program_buf, $_) foreach qw(clean clean-all);
         unlink $program_buf;
     }
@@ -102,29 +163,37 @@ SKIP: {
 
     is_deeply([split /\n/, qx(cat $infile2 | $program none/none)], [split /\n/, $repeated], "read ${\length $repeated} bytes (BUF_SIZE=$BUF_SIZE{normal})");
 
-    my $colored_text = qx(echo "foo bar baz" | $program red);
-    my $sequences = 0;
-    $sequences++ while $colored_text =~ /\e\[\d+m/g;
-    is($sequences, 2, 'count of sequences printed');
+    {
+        my $colored_text = qx(printf '%s\n' "foo bar baz" | $program red);
+        my $sequences = 0;
+        $sequences++ while $colored_text =~ /\e\[\d+m/g;
+        is($sequences, 2, 'count of sequences printed');
+    }
 
-    is(qx(echo -n "hello\nworld\r\n" | $program none/none), "hello\nworld\r\n", 'stream mode');
+    is(qx(printf %s "hello\nworld\r\n" | $program none/none), "hello\nworld\r\n", 'stream mode');
 
-    is(system("echo \"hello world\" | $program random --exclude-random=black >/dev/null 2>&1"), 0, 'switch exclude-random');
+    is(system(qq(printf '%s\n' "hello world" | $program random --exclude-random=black >/dev/null 2>&1)), 0, 'switch exclude-random');
 
     SKIP: {
         skip 'valgrind not found', 1 unless system('which valgrind >/dev/null 2>&1') == 0;
         like(qx(valgrind $program none/none $infile1 2>&1 >/dev/null), qr/no leaks are possible/, 'valgrind memleaks');
     }
 
+    {
+        my $debug = tmpnam();
+        is(system("$compiler -DDEBUG -o $debug $source"), 0, 'debugging build');
+        unlink $debug if -e $debug;
+    }
+
     print <<'EOT';
 Colors
 ======
 EOT
-    foreach my $color (qw(none black red green yellow blue cyan magenta white default random)) {
-        system("echo $color | $program $color");
+    foreach my $color (qw(none black red green yellow blue magenta cyan white default random)) {
+        system(qq(printf '%s\n' "$color" | $program $color));
         next if $color eq 'none';
         my $bold_color = ucfirst $color;
-        system("echo $bold_color | $program $bold_color");
+        system(qq(printf '%s\n' "$bold_color" | $program $bold_color));
     }
 
     unlink $program;